[bug] Able to download expired artifacts when rerunning workflow.

[jfrost-mo]

What happened?

Rerunning a failed action after 26 hours, I was surprised when an artifact with retention-days: 1 was still able to be downloaded. If retention days is only meant to be an approximation this should be documented.

The original run: https://github.com/MetOffice/CSET/actions/runs/7287909941/job/19859535403#step:5:1 The later run: https://github.com/MetOffice/CSET/actions/runs/7287909941/job/19894980822#step:5:1

What did you expect to happen?

For the workflow to fail with something like "artifact not found", or "artifact expired".

How can we reproduce it?

I've make a minimal demonstration at https://github.com/jfrost-mo/artifact-expiry, though it does require waiting 24 hours for the artifact to expire.

Anything else we need to know?

No response

What version of the action are you using?

v4 (SHA:f44cd7b40bfd40b6aa1cc1b9b5b7bf03d3c67110)

What are your runner environments?

linux

Are you on GitHub Enterprise Server? If so, what version?

GH Enterprise Cloud