Question: Deployment error instead of skipped when triggered from pull-request

[feryardiant]

Hi there,

Just try out this action to deploy our website, I noticed that if the workflow is triggered by pull-request it's error without any info, like this

while in the documentation stated as it should be skipped

This step is skipped if the workflow was triggered by a pull request.

Is it a bug or actually an expected feature?

Regards,

[feryardiant]

Apparently it still needs to have if: github.event_name == 'push' to make it skipped on pull-request.

deploy:
  runs-on: ubuntu-latest
  if: github.event_name == 'push'
  needs: build

[yoannchaudet]

@feryardiant Thank you for opening this. We will correct the documentation. We have decided to have the starter workflows only trigger on the default branch and not track pull requests at the moment (e.g. here).

[NicolasMassart]

Having it running from pull-request would be awesome as it would enable to host previews of the site changes in pages directly. (ideally in a subfolder like https://user.github.io/project/pull-request/123/)

[yoannchaudet]

Well I am late but the documentation change was merged a while ago!

@NicolasMassart One day!