delete-package-versions icon indicating copy to clipboard operation
delete-package-versions copied to clipboard

Support multiple packages

Open OmarCastro opened this issue 2 years ago • 8 comments

This PR adds support for multiple packages, a requested feature in #65. A new field package-names that supports this feature was added to make the code backward compatible.

OmarCastro avatar Apr 04 '22 15:04 OmarCastro

Thanks @OmarCastro for the PR. Will take a look in the week of 18 April.

NamrataJha avatar Apr 08 '22 10:04 NamrataJha

@NamrataJha is there any update?

carlos-m-rodrigues avatar May 03 '22 10:05 carlos-m-rodrigues

I feel like this is a very important feature. Any updates @NamrataJha ?

ivanaguilario avatar May 29 '22 15:05 ivanaguilario

Also I am still not able to run the action. I am using this workflow for testing. The action is not able to fetch package-version-ids.

image

Also you will need to add package-names entry here in this action.yml file to remove the runtime warning.

NamrataJha avatar May 31 '22 18:05 NamrataJha

Also I am still not able to run the action. I am using this workflow for testing. The action is not able to fetch package-version-ids.

image

Also you will need to add package-names entry here in this action.yml file to remove the runtime warning.

After analyzing action.yml and package.json, I noticed I have to run the pack script instead of build before commit, so the script was outdated

After that, all new commits now have dist/index.jsupdated

OmarCastro avatar Jun 01 '22 11:06 OmarCastro

I have been testing this feature with success using this workflow

image

One thing I noticed is the minimal information on the logs, only total number of versions deleted. With this feature implemented, I propose to add the number of versions removed by package

OmarCastro avatar Jun 01 '22 13:06 OmarCastro

@NamrataJha Is there any update on this?

carlos-m-rodrigues avatar Jul 14 '22 10:07 carlos-m-rodrigues

Hello @OmarCastro

We have released a major update for this action. See the release here. Could you please rebase your changes against main and submit the PR again?

nishthaGupta avatar Jan 05 '23 11:01 nishthaGupta