create-release icon indicating copy to clipboard operation
create-release copied to clipboard

[RFC] If encounter duplicate releases, change get tag info

Open DiamondYuan opened this issue 4 years ago • 4 comments

I have 2 workflow. Create mac and windows version. If first workflow success , second workflow will failed. i think create-release support ignore duplicate and return the info of duplicate releases.

DiamondYuan avatar Apr 01 '20 09:04 DiamondYuan

Add a new config allow_duplicate,if duplicate, will return correct outputs.

name: Release

on:
  push:
    branches:
      - master

jobs:
  build_on_win:
    runs-on: windows-latest
    steps:
      - name: Create Release
        id: create_release
        uses: actions/create-release@v1
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          allow_duplicate: true
          tag_name: ${{ github.ref }}
          release_name: Release ${{ github.ref }}
          draft: false
          prerelease: false
      - name: Upload Release Asset
        id: upload-release-asset
        uses: actions/upload-release-asset@v1
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          upload_url: ${{ steps.create_release.outputs.upload_url }}
          asset_path: ./out/umi-electron-boilerplate.zip
          asset_name: umi-electron-boilerplate.zip
          asset_content_type: application/zip

DiamondYuan avatar Apr 01 '20 09:04 DiamondYuan

i can make a pr

DiamondYuan avatar Apr 01 '20 09:04 DiamondYuan

As I usually create releases manually, I don't really need create-release, but since actions/upload-release-asset@v1 is configured with upload_url: ${{ steps.create_release.outputs.upload_url }}, I'm unable to upload release assets without create-release executing successfully.

Allowing create-release to succeed given an existing release would help remedy this problem.

asbjornu avatar Apr 20 '20 10:04 asbjornu

As I usually create releases manually, I don't really need create-release, but since actions/upload-release-asset@v1 is configured with upload_url: ${{ steps.create_release.outputs.upload_url }}, I'm unable to upload release assets without create-release executing successfully.

Allowing create-release to succeed given an existing release would help remedy this problem.

https://github.com/DiamondYuan/umi-electron-boilerplate/blob/master/actions/release/action.yml I fork and move action to my own project.

DiamondYuan avatar Apr 21 '20 10:04 DiamondYuan