checkout icon indicating copy to clipboard operation
checkout copied to clipboard

Switch to API First (cant make a discussion)

Open provenvelocity opened this issue 3 months ago • 3 comments

So the current structure of this code uses git clone, as primary way to retrieve the code. For GHEC customers this is a costly call. It can take several ( 4-8 ) API calls and internal cross process calls to get one git clone to function. While the alternative is to use the API call directly to do a clone of a ref only uses one API call and 1 auth call internaly. This is a drastic improvement in the total number of calls.

By switching this will help the load on all GHEC cusomters and also help github.com by reducing all those unn needed calls.

I would propos for all simple calls use api and for all more complex calls and setup's fall back to git clone.

Thanks Joshua

provenvelocity avatar Sep 24 '25 16:09 provenvelocity

Wouldn't this mean there's no .git, submodules, LFS and pr merge refs? And therefore the only viable way to implement this would be to have it as an option rather as the default behaviour?

salmanmkc avatar Oct 18 '25 10:10 salmanmkc

We do 15k+ runs a day... and all of them are directly a ref... most people do just that. Some use sub modules and if so they can specify that... I would wonder if we could get stats of how many calls use sub modules of this repo. But I'm setting most are just a direct ref of the repo alone.

On Sat, Oct 18, 2025 at 3:52 AM Salman Chishti @.***> wrote:

salmanmkc left a comment (actions/checkout#2277) https://github.com/actions/checkout/issues/2277#issuecomment-3418214177

Wouldn't this mean there's no .git, submodules, LFS and pr merge refs? And therefore the only viable way to implement this would be to have it as an option rather as the default behaviour?

— Reply to this email directly, view it on GitHub https://github.com/actions/checkout/issues/2277#issuecomment-3418214177, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK2F5C53N3RIUOPOANGXNH33YILW7AVCNFSM6AAAAACHMUDBGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMJYGIYTIMJXG4 . You are receiving this because you authored the thread.Message ID: @.***>

provenvelocity avatar Oct 18 '25 14:10 provenvelocity

Ok scratch that I just found a 78 core all machined and half way through the project Tim going to buy lol...

On Sat, Oct 18, 2025 at 7:17 AM Joshua Schipper @.***> wrote:

We do 15k+ runs a day... and all of them are directly a ref... most people do just that. Some use sub modules and if so they can specify that... I would wonder if we could get stats of how many calls use sub modules of this repo. But I'm setting most are just a direct ref of the repo alone.

On Sat, Oct 18, 2025 at 3:52 AM Salman Chishti @.***> wrote:

salmanmkc left a comment (actions/checkout#2277) https://github.com/actions/checkout/issues/2277#issuecomment-3418214177

Wouldn't this mean there's no .git, submodules, LFS and pr merge refs? And therefore the only viable way to implement this would be to have it as an option rather as the default behaviour?

— Reply to this email directly, view it on GitHub https://github.com/actions/checkout/issues/2277#issuecomment-3418214177, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK2F5C53N3RIUOPOANGXNH33YILW7AVCNFSM6AAAAACHMUDBGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMJYGIYTIMJXG4 . You are receiving this because you authored the thread.Message ID: @.***>

provenvelocity avatar Oct 19 '25 17:10 provenvelocity