fix: support pathname except ssh
In some cases pathname is required, but SSH does not support pathname.
close #1242
Any movement on this PR? Really waiting on this feature to complete a new system for work environment.
Just FYI, I think we can temporally reference this update as follows:
steps:
- uses: ischanx/checkout@06c611454073903c9d44641d7e085b21115d3dcf
@TingluoHuang would you like to have a look on this?
@TingluoHuang would you like to have a look on this?
@megamanics Could we tempt you pretty please? :pray: :blue_heart:
Successfully tested on a gitea-instance behind a proxy and with subpath
@TingluoHuang would you like to have a look on this?
@megamanics Could we tempt you pretty please? 🙏 💙
please add some test cases to demonstrate its usage.
@ischanx would you please update the merge request or maybe you could grant me or @Reverier-Xu write permission on your fork and so maybe we could finish things up?
👋 This is not something we currently plan to support - see https://github.com/actions/checkout/issues/1242#issuecomment-1773409781 for more info.
@joshmgross you don't need to plan to support, it's already there please understand how open-source works, at least try to understand, will you?
@joshmgross you don't need to plan to support, it's already there please understand how open-source works, at least try to understand, will you?
It's obvious what Micro$oft is trying to do with this. It'll just be up to Gitea, Forgejo, etc to fork actions and prevent actions from requesting GitHub by default and instead use Instance actions. At least that won't be difficult, just a base uri change.
bump
omg...
I've used forgejo for my private project. And I've set up to use mydomain.com/git/ for the forgejo instance. I solved everything until I found that actions/checkout in github is broken.
I don't understand one thing: what to support here? You have already a working patch, so what is the problem? Until someone won't explain, I would say it's a hipocrisy in front of open source code community.
I've used forgejo for my private project. And I've set up to use mydomain.com/git/ for the forgejo instance. I solved everything until I found that actions/checkout in github is broken.
I don't understand one thing: what to support here? You have already a working patch, so what is the problem? Until someone won't explain, I would say it's a hipocrisy in front of open source code community.
Microsoft's EEE-history at work here, that's the problem. They don't love open-source, they only love profit they get from it. There's a patched actions somewhere that you can default to (it also aliases it for anyone that uses "actions/checkout") that has the fix...I can't remember where. Either it was a Gitea fork someone did or a Forgejo one. I wish I could recall the project, they keep it updated with automatic patches and it's for Gitea/Forgejo.
I've used forgejo for my private project. And I've set up to use mydomain.com/git/ for the forgejo instance. I solved everything until I found that actions/checkout in github is broken. I don't understand one thing: what to support here? You have already a working patch, so what is the problem? Until someone won't explain, I would say it's a hipocrisy in front of open source code community.
Microsoft's EEE-history at work here, that's the problem. They don't love open-source, they only love profit they get from it. There's a patched actions somewhere that you can default to (it also aliases it for anyone that uses "actions/checkout") that has the fix...I can't remember where. Either it was a Gitea fork someone did or a Forgejo one. I wish I could recall the project, they keep it updated with automatic patches and it's for Gitea/Forgejo.
If you could find it, it would be great, because it seems repos of checkout at official Gitea and Forgejo are just mirrors
I've used forgejo for my private project. And I've set up to use mydomain.com/git/ for the forgejo instance. I solved everything until I found that actions/checkout in github is broken. I don't understand one thing: what to support here? You have already a working patch, so what is the problem? Until someone won't explain, I would say it's a hipocrisy in front of open source code community.
Microsoft's EEE-history at work here, that's the problem. They don't love open-source, they only love profit they get from it. There's a patched actions somewhere that you can default to (it also aliases it for anyone that uses "actions/checkout") that has the fix...I can't remember where. Either it was a Gitea fork someone did or a Forgejo one. I wish I could recall the project, they keep it updated with automatic patches and it's for Gitea/Forgejo.
If you could find it, it would be great, because it seems repos of checkout at official Gitea and Forgejo are just mirrors
It's been quite a while, I think this was it: https://gitea.com/ScMi1/checkout
Edit: I don't know if it has been maintained, though actions are usually simple.
I've used forgejo for my private project. And I've set up to use mydomain.com/git/ for the forgejo instance. I solved everything until I found that actions/checkout in github is broken. I don't understand one thing: what to support here? You have already a working patch, so what is the problem? Until someone won't explain, I would say it's a hipocrisy in front of open source code community.
Microsoft's EEE-history at work here, that's the problem. They don't love open-source, they only love profit they get from it. There's a patched actions somewhere that you can default to (it also aliases it for anyone that uses "actions/checkout") that has the fix...I can't remember where. Either it was a Gitea fork someone did or a Forgejo one. I wish I could recall the project, they keep it updated with automatic patches and it's for Gitea/Forgejo.
If you could find it, it would be great, because it seems repos of checkout at official Gitea and Forgejo are just mirrors
It's been quite a while, I think this was it: https://gitea.com/ScMi1/checkout
I believe it was. https://gitea.com/ScMi1/checkout/src/commit/f4c387e22b287332b0e22ca90fc847115f27c0db/src/url-helper.ts#L15 seems to be in spirit of the fork.
Though it doesn't have updates for a while. IDK if it's ok.
I've used forgejo for my private project. And I've set up to use mydomain.com/git/ for the forgejo instance. I solved everything until I found that actions/checkout in github is broken. I don't understand one thing: what to support here? You have already a working patch, so what is the problem? Until someone won't explain, I would say it's a hipocrisy in front of open source code community.
Microsoft's EEE-history at work here, that's the problem. They don't love open-source, they only love profit they get from it. There's a patched actions somewhere that you can default to (it also aliases it for anyone that uses "actions/checkout") that has the fix...I can't remember where. Either it was a Gitea fork someone did or a Forgejo one. I wish I could recall the project, they keep it updated with automatic patches and it's for Gitea/Forgejo.
If you could find it, it would be great, because it seems repos of checkout at official Gitea and Forgejo are just mirrors
It's been quite a while, I think this was it: https://gitea.com/ScMi1/checkout
I believe it was. https://gitea.com/ScMi1/checkout/src/commit/f4c387e22b287332b0e22ca90fc847115f27c0db/src/url-helper.ts#L15 seems to be in spirit of the fork.
Though it doesn't have updates for a while. IDK if it's ok.
Maybe, I don't recall. :/
Even I find this a super lousy response (if it can be called that), and I don't even have need of this anymore. Come on GH peeps we can do better than this.
Even I find this a super lousy response (if it can be called that), and I don't even have need of this anymore. Come on GH peeps we can do better than this.
Microsoft does not make money from Gitea/Forgejo's existence more than developer subscriptions, in my guess, not to mention Gitea/Forgejo are free(er) alternatives to the upsell-w---e they own called GitHub. This would never be a priority for them. Microsoft is -not- FOSS-friendly, despite their little "M$ <3 Linux" bs.
I've used forgejo for my private project. And I've set up to use mydomain.com/git/ for the forgejo instance. I solved everything until I found that actions/checkout in github is broken.
I don't understand one thing: what to support here? You have already a working patch, so what is the problem? Until someone won't explain, I would say it's a hipocrisy in front of open source code community.
This is also getting on my nerves, has anyone got a working fork? The ischanx one gives me "Cannoty find node in PATH" sunure what that is about
I have it just working. Though, I've rebased the patch for myself, but it works.