cache fix: fix cache-hit value when cache not found

fix: fix cache-hit value when cache not found

Open bchen1029 opened this issue 2 years ago • 6 comments

related to https://github.com/github/docs/pull/18524

set cache-hit to false when there is no cache matched

Jul 26 '22 07:07 bchen1029

Hoping this is a major priority! thx!

Aug 16 '22 06:08 bchen1029

@bishal-pdMSFT how to pass the CI testing? Is run npm run build and add a new commit the right approach?

Aug 25 '22 16:08 bchen1029

@vsvipul would you mind help me out with this PR and review it if you're free? really appreciate.

Aug 30 '22 02:08 bchen1029

@bchen1029 Please fix the failing checks. Updating the branch and then running npm run build should fix it ig.

Aug 30 '22 05:08 vsvipul

@bchen1029 Please fix the failing checks. Updating the branch and then running npm run build should fix it ig.

@vsvipul I've fixed the checks, hoping this PR would be helpful and could be merged. Thank you very much for your help.

Sep 04 '22 12:09 bchen1029

@aparna-ravindra would you mind help approve/check this PR?

Oct 03 '22 04:10 bchen1029

related to github/docs#18524

set cache-hit to false when there is no cache matched

Nov 22 '22 00:11 Jimimaku

@thecontemoraryflorals feel free to ping me with any suggestion for merge this PR. really appreciate.

May 19 '23 03:05 bchen1029