cache icon indicating copy to clipboard operation
cache copied to clipboard

Add PowerShell to examples.md

Open potatoqualitee opened this issue 4 years ago β€’ 3 comments

This PR adds PowerShell to the examples.md and includes all appropriate directories for each OS.

Working example can be seen here: https://github.com/potatoqualitee/tentools/runs/1222924184?check_suite_focus=true

potatoqualitee avatar Oct 07 '20 20:10 potatoqualitee

@potatoqualitee Can you please resolve the conflicts here?

Phantsure avatar Jun 06 '22 11:06 Phantsure

@potatoqualitee Can you kindly look at Josh's comment? Thanks

Phantsure avatar Jun 07 '22 13:06 Phantsure

Hello I am on vacation and will set this to unread and address when I get back next week πŸ‘πŸΌπŸ‘πŸΌ

potatoqualitee avatar Jun 10 '22 00:06 potatoqualitee

@potatoqualitee Friendly ping.

Phantsure avatar Sep 06 '22 11:09 Phantsure

thanks so much for the friendly ping, i will mark this notification as unread and return momentarily πŸ”œ

potatoqualitee avatar Sep 07 '22 08:09 potatoqualitee

@LaurentDardenne contributed an incredible PR to my potatoqualitee/psmodulecache cacher and may have the solution for this. I'll take a look at their solution and report back.

potatoqualitee avatar Sep 13 '22 06:09 potatoqualitee

After some review, it seems too complex to make as an example. Anyone who wants to cache PowerShell files should use https://github.com/marketplace/actions/powershell-module-cache πŸ˜…

Thank you all for your time and effort.

potatoqualitee avatar Sep 13 '22 07:09 potatoqualitee

@joshmgross

Could we add a comment to make it clear that the cache key here should match the modules listed

Hello, the v5.0 documentation details the construction of the key. The key is changed and will generate a new cache:

  • if we add a new module name or remove one from the list,
  • if an automatic update is requested and a new version exists.

The current documentation. The documentation of the next evolution.

I didn't state how 'actions/cache' works.

LaurentDardenne avatar Sep 13 '22 16:09 LaurentDardenne

Thanks @LaurentDardenne, I think this works better as a separate action than an example for actions/cache.

joshmgross avatar Sep 13 '22 16:09 joshmgross