cache icon indicating copy to clipboard operation
cache copied to clipboard

This action is lacking maintenance

Open IanButterworth opened this issue 1 year ago • 13 comments

PRs are not being reviewed nor is their CI is being run.

Please add support to https://github.com/orgs/community/discussions/121811 or raise the issue if you know a better way.

IanButterworth avatar May 16 '24 03:05 IanButterworth

Ooo

Gabrielpereira765 avatar May 16 '24 11:05 Gabrielpereira765

0000oo

Gabrielpereira765 avatar May 16 '24 11:05 Gabrielpereira765

Gostei

Gabrielpereira765 avatar May 16 '24 11:05 Gabrielpereira765

The CODEOWNERS file in this repo suggests that maybe we should ping the @actions/actions-cache team.

https://github.com/actions/cache/blob/0c45773b623bea8c8e75f6c82b208c3cf94ea4f9/.github/CODEOWNERS#L1-L1

DilumAluthge avatar May 20 '24 22:05 DilumAluthge

Hmmm. It seems that I'm not able to ping the @actions/actions-cache team.

DilumAluthge avatar May 20 '24 22:05 DilumAluthge

What is going on? Any kind of information at all as to why there is no maintenance of any kind in this repo for many months would be helpful. Sorry for the ping and thanks.

@andrejusk @bryanmacfarlane @cheshire137 @chrispat @DanRigby @dhadka @GrantBirki @joshmgross @marzvrover @mikhailkoliada @nikola-jokic @philip-gai @pje @rentziass @TingluoHuang

bearfriend avatar Jun 06 '24 13:06 bearfriend

I filed a GitHub support ticket earlier this week and got back

After review of the Community entry, I've reached out to our development teams internally providing the entry as well as the associated open PRs for further review. I'll update you as I learn more and thank you in advance for your patience.

IanButterworth avatar Jun 06 '24 13:06 IanButterworth

👋 Hey everyone,

Just a quick update - your concerns have been heard and I'm working on getting a proper response.

This action is still being supported by GitHub, but I totally understand the concern around the lack of timely responses on issues and pull requests. If there are any urgent bug fixes or security issues, please let me know and I'll make sure they're prioritized.

joshmgross avatar Jun 06 '24 16:06 joshmgross

Thanks @joshmgross

Part of the pain of not having prompt maintenance attention is that because CI is set to run on approval for new contributors PRs like https://github.com/actions/cache/pull/1325 take a lot longer to actually be tested and contributers get fatigued.

It's a bigger discussion, but I hope that either someone can stay on top of promptly running CI for new contributions, or that setting is disabled.

IanButterworth avatar Jun 07 '24 12:06 IanButterworth

That makes sense @IanButterworth, thanks for sharing your perspective.

I'd recommend testing changes locally or within workflows on a fork to validate them - that's going to be a much faster feedback loop than waiting on someone to approve runs on a pull request.

We cannot disable that setting at this time, it's necessary to prevent abusive actors from running arbitrary workflows on our repositories.

joshmgross avatar Jun 10 '24 20:06 joshmgross

Not being able to disable the setting is understandable, but the fact that CI still hasn't been run on https://github.com/actions/cache/pull/1325 really illustrates the issue. The submitter stated that tests pass locally for them, but no response.

I guess I don't understand what's going wrong here. Enough noise has been made by myself and others, I believe.

IanButterworth avatar Jun 10 '24 21:06 IanButterworth

I was made of aware of #1325 on Thursday and reviewed it then asking for another test case. I'm still following up internally to see if there's a better option than the hard-coded output that's mixed in with user-provided outputs from all existing steps.

As for the current status of this action and what we can do to improve here from a community perspective, I'm still working on that internally and don't have anything more to share at this time.

joshmgross avatar Jun 10 '24 21:06 joshmgross

I do appreciate your efforts. Thanks

IanButterworth avatar Jun 10 '24 21:06 IanButterworth

Any update on why this action is no longer maintained? @joshmgross

StudioLE avatar Jul 24 '24 12:07 StudioLE

Sorry for the quietness on this, and our other Actions! We are looking at how we better support our Actions across the board at the moment as we have been quiet on a bunch of them.

On cache in particular, we are working on the cache itself at the moment so we can get a cache >10gb. We hope to have a beta of that (probably private beta but we will see) by the end of the year :)

nebuk89 avatar Jul 25 '24 16:07 nebuk89

Please disable stale bot on this repo. The rate of maintenance attention is slower than the stale bot cycle. It's illogical to use it here.

IanButterworth avatar Aug 06 '24 11:08 IanButterworth

I've disabled our stale workflow for now - https://github.com/actions/cache/actions/workflows/close-inactive-issues.yml

joshmgross avatar Aug 06 '24 18:08 joshmgross

@joshmgross with https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/ will this action get better attention? Like updating to node20 which has lingered since Februrary https://github.com/actions/cache/pull/1326

IanButterworth avatar Sep 16 '24 17:09 IanButterworth

Like updating to node20 which has lingered since February #1326

This action has supported Node 20 since January https://github.com/actions/cache/releases/tag/v4.0.0

#1326 is a development-only change.

joshmgross avatar Sep 17 '24 14:09 joshmgross

Ah ok. Because development is paused on the action, no need to update development deps? Adding a comment on that PR would be helpful.

IanButterworth avatar Sep 17 '24 14:09 IanButterworth

Thanks @joshmgross I don't think this needs to be open any longer

IanButterworth avatar Oct 07 '24 17:10 IanButterworth