cache icon indicating copy to clipboard operation
cache copied to clipboard

v4.0 save always not working

Open DanMawdsleyBA opened this issue 1 year ago • 6 comments

I have setup the save always to true such that the cache step should always fail even if one of the tasks fail. See screenshots below: Save always set to true in step: image

Then further in the job a step fails but the post cache step is not run unlike the post repositry setup: image

Related to https://github.com/actions/cache/pull/1242

DanMawdsleyBA avatar Jan 30 '24 09:01 DanMawdsleyBA

For context this is how I did save cache in v3:

image

I think we can also optimise like this to not attempt to save cache when there was a cache hit

DanMawdsleyBA avatar Jan 30 '24 09:01 DanMawdsleyBA

I am also facing this issue. With save-always: true, the Post Cache is still skipped if the previous build step has failed:

image

SukkaW avatar Feb 08 '24 15:02 SukkaW

We're observing the same issue. It just doesn't seem to work as documented. image

sascha-wolf avatar Feb 27 '24 07:02 sascha-wolf