cache icon indicating copy to clipboard operation
cache copied to clipboard

Add dart example

Open Yakiyo opened this issue 2 years ago • 8 comments

Description

I've added an example for using the action within a dart repository

Motivation and Context

Faster workflows in any dart project.

How Has This Been Tested?

I've tested the same code snippet in the example in one of my projects and it ran as intended.

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Documentation (add or update README or docs)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

Yakiyo avatar Jun 15 '23 17:06 Yakiyo

Uploading 1684654587068.jpg…

nhan19977 avatar Jun 18 '23 21:06 nhan19977

Nhan

nhan19977 avatar Jun 18 '23 21:06 nhan19977

Nhab

nhan19977 avatar Jun 18 '23 21:06 nhan19977

Trường Võ Văn Kiệt

nhan19977 avatar Jun 18 '23 21:06 nhan19977

If you use subosito/flutter-action@v2, the pub cache is in a different location:

# linux
FLUTTER_ROOT: /opt/hostedtoolcache/flutter/stable-3.10.6-x64
PUB_CACHE: /opt/hostedtoolcache/flutter/stable-3.10.6-x64/.pub-cache

# macos
FLUTTER_ROOT: /Users/runner/hostedtoolcache/flutter/stable-3.10.6-x64
PUB_CACHE: /Users/runner/hostedtoolcache/flutter/stable-3.10.6-x64/.pub-cache

# windows
FLUTTER_ROOT: C:\hostedtoolcache\windows\flutter\stable-3.10.6-x64
PUB_CACHE: C:\hostedtoolcache\windows\flutter\stable-3.10.6-x64/.pub-cache

adil192 avatar Aug 01 '23 05:08 adil192

If you use subosito/flutter-action@v2, the pub cache is in a different location:

# linux
FLUTTER_ROOT: /opt/hostedtoolcache/flutter/stable-3.10.6-x64
PUB_CACHE: /opt/hostedtoolcache/flutter/stable-3.10.6-x64/.pub-cache

# macos
FLUTTER_ROOT: /Users/runner/hostedtoolcache/flutter/stable-3.10.6-x64
PUB_CACHE: /Users/runner/hostedtoolcache/flutter/stable-3.10.6-x64/.pub-cache

# windows
FLUTTER_ROOT: C:\hostedtoolcache\windows\flutter\stable-3.10.6-x64
PUB_CACHE: C:\hostedtoolcache\windows\flutter\stable-3.10.6-x64/.pub-cache

Wouldnt that be because flutter packages its own version of the dart sdk wouldnt it. That would definitely differ from just using dart. Not sure wether that needs to be specified or not.

Yakiyo avatar Aug 01 '23 10:08 Yakiyo

Wouldnt that be because flutter packages its own version of the dart sdk wouldnt it.

It's just an environment variable set by flutter-action (see the code snippet).

Not sure wether that needs to be specified or not.

Since flutter and subosito/flutter-action are quite popular, maybe a separate Flutter section should be added alongside the Dart section? I feel like just having the dart section would cause some confusion

adil192 avatar Aug 01 '23 16:08 adil192

Since flutter and subosito/flutter-action are quite popular, maybe a separate Flutter section should be added alongside the Dart section? I feel like just having the dart section would cause some confusion

yes, i also feel like there should be separate section for flutter but idk if this is allowed. if one of the maintainers replied maybe something could be done.

Yakiyo avatar Aug 01 '23 16:08 Yakiyo