actions-runner-controller
actions-runner-controller copied to clipboard
Job repository value is set to the repository of the shared workflow instead of the caller repository
Checks
- [x] I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
- [x] I am using charts that are officially provided
Controller Version
0.11.0
Deployment Method
ArgoCD
Checks
- [x] This isn't a question or user support case (For Q&A and community support, go to Discussions).
- [x] I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes
To Reproduce
Run a job using a reusable workflow in another repository.
Note: It doesn't seem to be consistent as you will see in the description
Describe the bug
JobRepositoryName on the CRD and metrics sometimes uses the repository of the reusable workflows instead of the repo using it. It seems like it is either always the reusable workflows or always the correct value without any changes to our deployment. Seems to me like an issue on the Github's backend side because the code parsing the job repo name from the message didn't change for a lot of time. You can see the following screen for our workflows jobrepository name. (Al these jobs are basically the same and all our workflows using ARC are using the same reusable workflows)
I saw someone else mention this in another another issue but it should be another issue.
Describe the expected behavior
JobRepository should be the value of the repository using the reusable workflows not the repository of the reusable workflow
Additional Context
I looked at the controller logs and runner pods logs but nothing looked valuable for this issue. If needed I will provide some
Controller Logs
N/A
Runner Pod Logs
N/A
Hello! Thank you for filing an issue.
The maintainers will triage your issue shortly.
In the meantime, please take a look at the troubleshooting guide for bug reports.
If this is a feature request, please review our contribution guidelines.
I am still on 0.11.0 but now it looks to be consistently set to the shared workflow's repository. I would rather have the callee's repository but I don't mind it as much since it is now consistent. Feel free to close the issue if the shared workflow's repo is the expected value
Feel free to close the issue if the shared workflow's repo is the expected value
Since this issue affects metrics, I would expect that it should be fixed.
We make heavy use of reusable workflows in our company and therefore we can't get accurate usage details for our individual repositories as a result of this bug.
I agree as well that getting the value of the callee is needed, whether it is through this label or another one.
@rentziass, this issue appears fixed on our end now.
Did you update something on the backend to resolve this?
I did two weeks ago and forgot to report back, yes 😅 sorry about that and thanks for the ping!
I did two weeks ago and forgot to report back, yes 😅 sorry about that and thanks for the ping!
No problem! It's confirmed fixed on our end, so this issue can probably be closed.
I can also confirm the fix, thanks :)