actions-runner-controller icon indicating copy to clipboard operation
actions-runner-controller copied to clipboard

ARC not working with an organization whose name ends in hyphen

Open and-es opened this issue 1 year ago • 2 comments

Checks

  • [X] I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
  • [X] I am using charts that are officially provided

Controller Version

0.9.3

Deployment Method

Helm

Checks

  • [X] This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • [X] I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

Follow Quickstart guide(https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/quickstart-for-actions-runner-controller) with an organization named "camphor-".
githubConfigUrl is "https://github.com/camphor-".

Describe the bug

Failed to create a runner scale set. The controller log says:

"error": "AutoscalingRunnerSet.actions.github.com \"arc-runner-set\" is invalid: metadata.labels: Invalid value: \"camphor-\": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')"}

Describe the expected behavior

Create a runner scale set successfully.

Additional Context

Nothing. I just follow the quickstart guide.

Controller Logs

https://gist.github.com/and-es/1456bf907dd2ddc1716881ce6a2e1224

Runner Pod Logs

No runner pods

and-es avatar Jul 16 '24 10:07 and-es

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

github-actions[bot] avatar Jul 16 '24 10:07 github-actions[bot]

I sent PR. Please review it.

and-es avatar Jul 16 '24 11:07 and-es

FWIW, I am also hitting this issue due to my GH username ending in a hyphen. I'll try @and-es's PR and see if it's enough to resolve the issue.

aidan- avatar Dec 29 '24 11:12 aidan-