migrating runner-scale-set by uninstall and reinstall helm release removes newly registered runner group

[networkhermit]

Checks

• [X] I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
• [X] I am using charts that are officially provided

Controller Version

0.8.3

Deployment Method

Helm

Checks

• [X] This isn't a question or user support case (For Q&A and community support, go to Discussions).
• [X] I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

1. Follow the official guide to deploy `gha-runner-scale-set-controller` and `gha-runner-scale-set` `demo-runner-group`

2. Set up a new cluster (environment) for migration testing, deploy `gha-runner-scale-set-controller` with the same credential.

3. When `demo-runner-group` still have several active runners, uninstall the `gha-runner-scale-set` `demo-runner-group` helm release from the old cluster.

4. Install the same `gha-runner-scale-set` `demo-runner-group` helm release in the new environment.

5. New actions begin to use the newly registered `demo-runner-group`, nothing is wrong here.

6. Wait for the old runners finished building, and the newly registered runner group is suddenly removed from the GitHub runners settings view.

Describe the bug

Newly registered runner group got removed by the controller when migration.

Describe the expected behavior

Newly registered runner group does not get removed by the controller when migration.

Additional Context

Not available.

Controller Logs

Not available.

Runner Pod Logs

Not available.

[github-actions[bot]]

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

[nikola-jokic]

Hey @networkhermit,

Thank you for reporting this issue and for writing it so clearly! I was able to reproduce it and I will update you on the progress here.