actions-runner-controller
actions-runner-controller copied to clipboard
actions
chore(chart): add DOCKER_IPTABLES_LEGACY env var to dind container
Tying up a loose end on this issue:
set DOCKER_IPTABLES_LEGACY=1 inside your dind pod, via an overwrite to the helm chart default variables (this should get added to the helm chart, if someone wants an easy PR)
@emesar thanks for picking this up. This PR looks to only address the issue for the new scale set chart. Would it be possible to also get the fix in for the old legacy chart?
I honestly don't understand why you don't approve and merge it. Yeah, it could be backported to the legacy chart, but you could also point to where the legacy chart is and we could get this sorted faster. Or even better, you could approve this, merge it and doing the backport yourself.
Not doing any of this is bad maintainer practice and I'm sorry if this sounds harmful
I honestly don't understand why you don't approve and merge it. Yeah, it could be backported to the legacy chart, but you could also point to where the legacy chart is and we could get this sorted faster. Or even better, you could approve this, merge it and doing the backport yourself.
Not doing any of this is bad maintainer practice and I'm sorry if this sounds harmful
@esanchezm was this addressed to me? I'm not a maintainer for the project so it's kinda out of my hands. I was merely hoping that @emesar would be so kind to also update the legacy chart in the same PR instead of someone else having to open a new PR 🤷
My apologies, @emilwangaa because I thought you were a maintainer. However, my point stands and I honestly don't understand why this is not being merged. Having it backported is not required to ignore it. Again, I'm sorry because I directed my message to you
@emesar thanks for picking this up. This PR looks to only address the issue for the new scale set chart. Would it be possible to also get the fix in for the old legacy chart?
@emilwangaa Sorry for the delay, was out of town for a bit and am only just getting back to this. I'll take a look tonight and see if I can get the fix in for the legacy chart too.
Would really appreciate this being merged... making things work without it is really sloppy and prone to human error
We are seeing this as a problem when updating our CI cluster to ubuntu 22.04. We have tried to set it at the host level to iptables-legacy, but it does not appear to be properly picked up.
We would really love to have this fix merged, so our manifest are way cleaner and easier to maintain 🚀
Just chiming in to support this PR - would a maintainer be able to explain what is needed to move it forward please? The alternative to this fix is an ugly template in each gha-runner-scale-set-controller
My apologies, @emilwangaa because I thought you were a maintainer. However, my point stands and I honestly don't understand why this is not being merged. Having it backported is not required to ignore it. Again, I'm sorry because I directed my message to you
@emesar didn't put copilot in the PR subject, that's why it's not merged... /s
I wish that wasn't true.
Why is this being ignored for so long? This PR can save a lot of hassle for so many people out there, who complain about dind issues. There's a really good chance this PR will make these issues go away and save those people hours of troubleshooting, as was my case. Will a maintainer chime in and review this? Please?