actions-runner-controller icon indicating copy to clipboard operation
actions-runner-controller copied to clipboard

Chart broken for kubernetes 1.19

Open jsotelo opened this issue 4 years ago • 2 comments

For kubernetes 1.19, both extensions/v1beta1 and networking.k8s.io/v1 coexist so this approach in fact breaks this helm chart since we end up with apiVersion: extensions/v1beta1 here but also hit the {{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1" }} conditional below producing the following error:

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "service" in io.k8s.api.networking.v1beta1.IngressBackend
helm.go:88: [debug] error validating "": error validating data: ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "service" in io.k8s.api.networking.v1beta1.IngressBackend

Originally posted by @jsotelo in https://github.com/actions-runner-controller/actions-runner-controller/pull/988#discussion_r779635311

jsotelo avatar Jan 07 '22 12:01 jsotelo

What would be the better approach to this?

samip5 avatar Jan 27 '22 19:01 samip5

What would be the better approach to this?

https://github.com/actions-runner-controller/actions-runner-controller/pull/988#discussion_r779694913

jsotelo avatar Jan 27 '22 20:01 jsotelo