cargo icon indicating copy to clipboard operation
cargo copied to clipboard

Add working-directory

Open MarcoPolo opened this issue 4 years ago • 10 comments

Fixes https://github.com/actions-rs/cargo/issues/6.

I wish this would be handled in the Github Actions Framework level. It seems silly that all actions are expected to provide something like this.

Prior Art: (Other actions also add this option. working-dir works with run


I recommend rebuilding this before publishing as a security best practice.

MarcoPolo avatar Apr 15 '20 20:04 MarcoPolo

Works great for me! https://github.com/fenollp/reMarkable-tools/runs/637142119?check_suite_focus=true Thanks :)

fenollp avatar May 01 '20 18:05 fenollp

Hey guys, any plans to accept this pr?

igormq avatar May 31 '20 22:05 igormq

This would be nice to have!

patrick-fitzgerald avatar Sep 09 '20 22:09 patrick-fitzgerald

Why hasn't this been merged yet? GH hasn't added support for working-directory for uses and this would really makes things great for us...

Karrq avatar Feb 11 '21 14:02 Karrq

Any updates for this PR?

anatawa12 avatar Jul 18 '21 12:07 anatawa12

This repo is dead

giansalex avatar Aug 20 '21 23:08 giansalex

Any updates on this PR? What's stopping it from being merged?

ozgunozerk avatar Jan 12 '22 06:01 ozgunozerk

The only maintainer of the @actions-rs organization, @svartalf, has been known to take protracted absences from the internet. Feel free to fork the project in @svartalf's absence.

fanninpm avatar Jan 14 '22 01:01 fanninpm

Hi, everyone. I'm well aware that this PR is quite stale, but at the moment I do not have neither resources nor time to maintain any of my open source projects. Hopefully there will be more time available for me closer to this spring, but not right now because my personal matters and well-being of me and my family are more important for me. Of course, we all can agree that communication should've been better, but at this point, it is what it is, unfortunately, and I am sorry about it.

Before you ask about adding more maintainers, I thought about it for a long time, but since @actions-rs are used heavily both by companies and individuals at this point for both public and private repos, there is a huge trust issue we should take into the consideration, because having a write access to these repositories provides a huge attack vector too. I prefer to keep these repos stale for now rather then accidentally allowing some malicious third party to get access to all these private repos, which will be way worse than not having some feature merged.

I do hope that I'll be able to get back to these repos some time soon.

P.S. Dear @fanninpm , I can't say I'm appreciating your negative implication in here

has been known to take protracted absences from the internet

I suggest you to re-consider your position on this topic and start behaving yourself; I do not own you anything (as a reminder, it is also explicitly stated in the project license) and how exactly I'm maintaining my projects or what spending my time on is also none of your business. Though I can agree that forking is always an option, there is a mention of it in #6 comments.

svartalf avatar Jan 14 '22 10:01 svartalf

Use this one instead: https://github.com/ClementTsang/cargo-action

YukiCoco avatar Oct 03 '22 12:10 YukiCoco