audit-check
audit-check copied to clipboard
[Security] Bump ws from 7.2.5 to 7.5.1
Bumps ws from 7.2.5 to 7.5.1. This update includes security fixes.
Vulnerabilities fixed
Sourced from The GitHub Security Advisory Database.
ReDoS in Sec-Websocket-Protocol header
Impact
A specially crafted value of the
Sec-Websocket-Protocolheader can be used to significantly slow down a ws server.Proof of concept
for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) { const value = 'b' + ' '.repeat(length) + 'x'; const start = process.hrtime.bigint();value.trim().split(/ *, */);
const end = process.hrtime.bigint();
console.log('length = %d, time = %f ns', length, end - start); }
Patches
... (truncated)
Affected versions: >= 7.0.0 < 7.4.6
Sourced from The GitHub Security Advisory Database.
ReDoS in Sec-Websocket-Protocol header
Impact
A specially crafted value of the
Sec-Websocket-Protocolheader can be used to significantly slow down a ws server.Proof of concept
for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) { const value = 'b' + ' '.repeat(length) + 'x'; const start = process.hrtime.bigint();value.trim().split(/ *, */);
const end = process.hrtime.bigint();
console.log('length = %d, time = %f ns', length, end - start); }
Patches
... (truncated)
Affected versions: >= 5.0.0 < 7.4.5
Sourced from The GitHub Security Advisory Database.
ReDoS in Sec-Websocket-Protocol header
Impact
A specially crafted value of the
Sec-Websocket-Protocolheader can be used to significantly slow down a ws server.Proof of concept
for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) { const value = 'b' + ' '.repeat(length) + 'x'; const start = process.hrtime.bigint();value.trim().split(/ *, */);
const end = process.hrtime.bigint();
console.log('length = %d, time = %f ns', length, end - start); }
Patches
... (truncated)
Affected versions: >= 5.0.0 < 7.4.6
Release notes
Sourced from ws's releases.
7.5.1
Bug fixes
- Fixed an issue that prevented the connection from being closed properly if an error occurred simultaneously on both peers (b434b9f1).
7.5.0
Features
- Some errors now have a
codeproperty describing the specific type of error that has occurred (#1901).Bug fixes
- A close frame is now sent to the remote peer if an error (such as a data framing error) occurs (8806aa9a).
- The close code is now always 1006 if no close frame is received, even if the connection is closed due to an error (8806aa9a).
7.4.6
Bug fixes
- Fixed a ReDoS vulnerability (00c425ec).
A specially crafted value of the
Sec-Websocket-Protocolheader could be used to significantly slow down a ws server.for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) { const value = 'b' + ' '.repeat(length) + 'x'; const start = process.hrtime.bigint();value.trim().split(/ *, */);
const end = process.hrtime.bigint();
console.log('length = %d, time = %f ns', length, end - start); }
The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.
In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the
--max-http-header-size=sizeand/or themaxHeaderSizeoptions.7.4.5
Bug fixes
... (truncated)
Commits
38c6c73[dist] 7.5.12916006[test] Add more tests forWebSocket.prototype.close()b434b9f[fix] Fix close edge casesc3fdc99[minor] Fix misleading comment145480a[test] Fix repeated typoe3f0c17[dist] 7.5.01d3f4cb[doc] Fix anchor tags for error codes6eea0d4[doc] Fix typobb5d44b[doc] Sort error codes alphabeticallyc6e3080[minor] Attach error codes to all receiver errors (#1901)- Additional commits viewable in compare view
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in your Dependabot dashboard:
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)