actions-on-google-nodejs icon indicating copy to clipboard operation
actions-on-google-nodejs copied to clipboard

userStorage not persisting

Open DecathectZero opened this issue 5 years ago • 3 comments

Currently, the behavior interfacing with the dialogflow API is if the userStorage does not change, actions-on-google does not send back the storage in the response. However, the next request no longer contains the userStorage properties.

I assume something changed with the dialogflow API and this is a side effect. It has lead to many actions breaking on my end.

The intended behavior now seems we need to send the userStorage with every response to persist it to the next request.

https://github.com/actions-on-google/actions-on-google-nodejs/blob/c12e5da0c1585dec0b276a973393adc8ae291a0c/src/service/actionssdk/conversation/conversation.ts#L539

DecathectZero avatar Dec 17 '19 18:12 DecathectZero

@Canain can you provide some insight on this?

Fleker avatar Dec 18 '19 16:12 Fleker

I can open a pull request for this and provide more insight if needed? @Fleker Noting this on behalf of Voiceflow, we host and deploy hundreds of google actions and this turned out to be a serious breaking bug for our users - my current fix has been to just include a randomly generated string with every userStorage to ensure the equality check fails.

DecathectZero avatar Jan 16 '20 23:01 DecathectZero

Hi, if this is the case then it is a bug on the platform end.

Can you provide some sample code that you used to test this behavior?

We will contact the engineering team for Dialogflow to investigate.

Canain avatar Jan 16 '20 23:01 Canain