actions-on-google-java icon indicating copy to clipboard operation
actions-on-google-java copied to clipboard
verified publisher icon actions-on-google

consider dropping JSONObject from the smarthome API surface

Open proppy opened this issue 6 years ago • 1 comments

Currently the libraries exposes JSONObject as part of the public smarthome API object: https://github.com/actions-on-google/actions-on-google-java/blob/7f3b1e2fd51e3b044380ea3c72722058ad99240f/src/main/kotlin/com/google/actions/api/smarthome/SmartHomeResponse.kt

This force reverse dependencies to both depens on org.json (as a direct dependency) and gson (transitively).

It would be nice if the library instead only surfaced standard Map<String, Object> types in the public API.

/cc @taycaldwell @Fleker

proppy avatar Dec 20 '19 09:12 proppy

Yeah we should keep this in mind for the future, although it would end up being a breaking change.

Fleker avatar Dec 20 '19 15:12 Fleker