pikaur icon indicating copy to clipboard operation
pikaur copied to clipboard

Suggest to install optional deps

Open actionless opened this issue 6 years ago • 6 comments

actionless avatar Feb 26 '18 00:02 actionless

Yes, it will be a very handy feature. When I install several packages at the same time, I just do not notice what additional dependencies there are.

Mauladen avatar Feb 28 '18 14:02 Mauladen

mb in [m]anual package selection i could present optional deps right after the package which depend on them but show optional deps commented out initially?

actionless avatar Feb 28 '18 15:02 actionless

Yeah, that's cool!

Mauladen avatar Feb 28 '18 17:02 Mauladen

@actionless, heya, this feature sounds cool and I've wanted something like this for awhile since sometimes it's easy to miss optional packages I may be interested in. Would be happy to give it a go and implement it but given I haven't done anything in pikaur yet (and my package management knowledge in general is not very deep) do you mind giving me some guidance before I start?

In particular:

  • Any specific interface you think would be reasonable? I think the idea of presenting a list after the [m]anual package selection section sounds reasonable but is anything else required? CLI options, config options etc.?
  • To confirm -- we need to scan for this before we install or update any packages, right?
  • Any interesting edge cases you think I need to be aware of?
  • And probably most importantly, do you think this would be a suitable first issue? I'm aware that this is probably more involved than the typical ones and I'm fine with it, just checking if implementing this requires a deep knowledge of the tool.

arturbalabanov avatar Feb 27 '20 10:02 arturbalabanov

thanks for your interest, @arturbalabanov

  1. i think it would be better to 1.1) in case if optional deps are available print the message: :: info: N optional deps found for packages: pkg1, pkg2, use Manual package selection to choose them 1.2) in [m]anual package selection show optional deps commented out:
mainpkgname                                  1.01 -> 1.1
# optdepname1 (for mainpkgname: Optdep1 description)        -> 1.0
# optdepname2 (for mainpkgname: Optdep2 description)        -> 1.0

by description i mean the text which goes in optdeps definition of PKGBUILD and explaining what feature that optdep adds to the main package 2) in InstallInfoFetcher while computing deps for installation prompt 3) for example when optional dep is one of the packages which gonna be installed explicitly or as normal dep of one of the packages which gonna be installed (in that case that optdep shouldn't be proposed) or when the same optdep is optdep for more than one package which are going to be installed (i;m not sure if it will be better to group them or print optdep twice under each package for each it's an optdep) 4) idk, but if you'll have more questions i'll be happy to guide/assist

actionless avatar Feb 27 '20 13:02 actionless

CLI options, config options etc.?

mb also to add CLI and config option to always install all optional deps by default

actionless avatar Mar 02 '20 10:03 actionless