actinia-core icon indicating copy to clipboard operation
actinia-core copied to clipboard

Black for actinia

Open anikaweinmann opened this issue 2 years ago • 1 comments

We want to use black to beautify actinia code.

We want to use some black in Workflows, so that workflows fails if the code is not black conform. Before the workflow is active we need to do black about the whole code.

anikaweinmann avatar Aug 03 '22 08:08 anikaweinmann

FYI, here the related GRASS GIS black workflow:

https://github.com/OSGeo/grass/blob/main/.github/workflows/black.yml

neteler avatar Aug 03 '22 08:08 neteler

actinia-core now has a black GHA worflow: https://github.com/mundialis/actinia_core/blob/main/.github/workflows/black.yml

For the plugins it has to be added:

Allready done for:

anikaweinmann avatar Nov 24 '22 11:11 anikaweinmann

From my point of view, megalinter is also fine, but I don't know if this would also change files like black does. I would suggest to not add black there and see how we get along with megalinter!?

mmacata avatar Nov 29 '22 16:11 mmacata

Linting in GHA and pre-commits should be added for actinia-core and Plugins; see https://github.com/mundialis/github-workflows

anikaweinmann avatar Aug 30 '23 08:08 anikaweinmann

See #469 (maybe close this one here)

mmacata avatar Aug 30 '23 15:08 mmacata