act-rules.github.io icon indicating copy to clipboard operation
act-rules.github.io copied to clipboard

Update ee13b5 and 1a02b0 rules to clarify that transcript for video content does not need to be visible

Open giacomo-petri opened this issue 1 year ago • 1 comments

Closes issue(s): #2186

Updates:

  • Added 1.3.1 secondary requirement for both:
    • Video element visual-only content has transcript (ee13b5)
    • Audio and visuals of video element have transcript (1a02b0)
  • Removed "visible" from Expectation of both:
    • Video element visual-only content has transcript (ee13b5)
    • Audio and visuals of video element have transcript (1a02b0)
  • Added assumption as per CG decision for both:
    • Video element visual-only content has transcript (ee13b5)
    • Audio and visuals of video element have transcript (1a02b0)
  • Added non-visible transcription passed example (Passed Example 3) for both:
    • Video element visual-only content has transcript (ee13b5)
    • Audio and visuals of video element have transcript (1a02b0)
  • Tweaked a little bit the wording of other passed examples to clarify they are visible and differentiate them from the non-visible one.
  • Added failing example (Failed Example 3) of transcript not included in the acc tree only for "Audio and visuals of video element have transcript (1a02b0)" since the other rule already had this failure in place.

Need for Call for Review: This will require a 2 weeks Call for Review


Pull Request Etiquette

When creating PR:

  • [ ] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • [ ] Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • [ ] Add yourself (and co-authors) as "Assignees" for PR.
  • [ ] Add label to indicate if it's a Rule, Definition or Chore.
  • [ ] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • [ ] Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • [ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

giacomo-petri avatar May 03 '24 09:05 giacomo-petri

Blocked by https://github.com/act-rules/act-rules.github.io/pull/2064 (pending merge of #2064)

giacomo-petri avatar May 30 '24 06:05 giacomo-petri

Discussion during F2F meeting: WCAG is moving toward saying that transcript do not necessarily need to be visible (reason, a gif qualifies as audio-less video, and an aria-label (not visible) is enough for it).

Hence, we should continue with this PR (and close #2064). We should add a background note explaining the reasoning. We should add a Passed Example with a video element and an aria-label. We could add a Best Practice rule requiring transcript t be visible.

Jym77 avatar Feb 07 '25 12:02 Jym77

Deploy Preview for act-rules ready!

Name Link
Latest commit c4c48c6d9e31301866f79f0db38b54b20f93fff9
Latest deploy log https://app.netlify.com/projects/act-rules/deploys/689997ad8945d80008d06065
Deploy Preview https://deploy-preview-2187--act-rules.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Aug 04 '25 14:08 netlify[bot]

Call for review ends September 8th.

giacomo-petri avatar Aug 22 '25 08:08 giacomo-petri

Personally I think an aria-label text equivalent under 1.1.1 is different than a transcript under 1.2.1. I still don't know how a person with low vision who isn't using a screen reader would be able to access or even know a transcript is available if it's positions off-screen with CSS.

mraccess77 avatar Aug 22 '25 12:08 mraccess77