act-rules
HTML page has non-empty title [2779a5]: Shadow root example - Included as failed example 6
Closes issue(s): #2179
Description:
Adding a failed example of an HTML page lacking a title but featuring a shadow root with a non-empty <title> that does not affect the page title into the HTML page has non-empty title [2779a5] rule.
Need for Call for Review: This will require a 1 week Call for Review
Pull Request Etiquette
When creating PR:
- [ ] Make sure you're requesting to pull a branch (right side) to the
developbranch (left side). - [ ] Make sure you do not remove the "How to Review and Approve" section in your pull request description
After creating PR:
- [ ] Add yourself (and co-authors) as "Assignees" for PR.
- [ ] Add label to indicate if it's a
Rule,DefinitionorChore. - [ ] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
- [ ] Optionally request feedback from anyone in particular by assigning them as "Reviewers".
When merging a PR:
- [ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.
How to Review And Approve
- Go to the “Files changed” tab
- Here you will have the option to leave comments on different lines.
- Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
- Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.
Hi @Jym77,
to be honest, it took me a while to figure out if Expectation 2 was supposed to clarify how to deal with shadow roots, but after reviewing the definitions, I think it's accurate. However, I do agree that it could be clearer and less time-consuming for users to understand how to handle shadow roots.
Hi @Jym77,
to be honest, it took me a while to figure out if Expectation 2 was supposed to clarify how to deal with shadow roots, but after reviewing the definitions, I think it's accurate. However, I do agree that it could be clearer and less time-consuming for users to understand how to handle shadow roots.
Yes, I think this is correct (this is also Alfa's interpretation). I think that this is a very old rule and we were not so conscious then about the differences between DOM and flat tree 😅 In any case, the example makes it clear that shadow DOM is ignored, so that's definitely going in the good direction.
