act-rules.github.io
act-rules.github.io copied to clipboard
Updating CG writing guidance with example removed from ACT format doc.
Updating writing guidelines documents with an example we originally had in the format but decided was better included in the writing guide. I haven't messed with these documents, so let me know if there is a better place to put the example than inline. I also don't know if this change requires a CFC, so let me know.
Need for Call for Review: << choose one of the following and remove the rest >> << check Process Document on Call for Review >> This can be merged with 1 approval << choose reason: editorial changes to website/test code, adding new contributor, other (explain). >> This will not require a Call for Review << choose reason(s): editorial changes (including to the applicability, expectation or examples section), changes to assumptions, background, accessibility support, change to website/test code (not rule), other (explain). >> This will require a 1 week Call for Review << small changes affecting a small number of test cases, if in doubt do not use this. >> This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of test cases, if in doubt, use this. >>
How to Review And Approve
- Go to the “Files changed” tab
- Here you will have the option to leave comments on different lines.
- Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
- Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.