act-rules.github.io icon indicating copy to clipboard operation
act-rules.github.io copied to clipboard

Adds a defintion for essential text change

Open tbostic32 opened this issue 2 years ago • 2 comments

In Text content that changes automatically can be paused, stopped or hidden it was determined that we need to have essential in the expectation. However, essential is an ambiguous term, so we need to create a new definition that handles the various cases where text changing is an essential function of a page.

Need for Call for Review: This will require a 1 week Call for Review

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

tbostic32 avatar Sep 07 '22 22:09 tbostic32

@carlosapaduarte From our review we found that the applicability is somewhat hard to understand, so I would like to propose the change below:

  1. Remove the no-child-changed and not-alone applicability conditions
  2. Modify the change condition to only consider the text content of child text nodes (only direct children, not all descendants)

At least my understanding was that the no-child-changed condition was meant to prevent an parent element from being applicable when a the text content of a child was changed. If we only consider the text content of child text nodes then the an ancestor node will never be applicable when one of its descendants text changes.

tbostic32 avatar Sep 28 '22 13:09 tbostic32

Waiting for subjective applicability / state discussions to resolve before picking this back up.

WilcoFiers avatar Jul 20 '23 13:07 WilcoFiers