act-rules.github.io
act-rules.github.io copied to clipboard
Update image-button-non-empty-accessible-name-59796f.md
Added:
- failed example 3
- updated "Accessibility Support" section
Closes issue: #1861
Need for Call for Review: This will require a 1 week Call for Review
Note: Sorry if I made mistakes while creating the pull request, this is my first pull request and first time I contribute to a GitHub project.
Pull Request Etiquette
When creating PR:
- [ ] Make sure you're requesting to pull a branch (right side) to the
develop
branch (left side). - [ ] Make sure you do not remove the "How to Review and Approve" section in your pull request description
After creating PR:
- [ ] Add yourself (and co-authors) as "Assignees" for PR.
- [ ] Add label to indicate if it's a
Rule
,Definition
orChore
. - [ ] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
- [ ] Optionally request feedback from anyone in particular by assigning them as "Reviewers".
When merging a PR:
- [ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.
How to Review And Approve
- Go to the “Files changed” tab
- Here you will have the option to leave comments on different lines.
- Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
- Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.
As per our conversation, I've removed Passed example 5 and I've opened an issue about how to handle those cases: #1954