act-rules.github.io icon indicating copy to clipboard operation
act-rules.github.io copied to clipboard

Definition of test instructions

Open ajanec01 opened this issue 4 years ago • 2 comments

Defining "Test instructions" for rules that require the tester to get a test case into a specific state.

Need for Final Call: none

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

ajanec01 avatar Aug 03 '21 10:08 ajanec01

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ajanec01 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 03 '21 10:08 CLAassistant

I'm also considering whether the test instructions should (also) be included in the example itself. So that a tester that navigates to the example's page (without going through the ACT rules page) can still see them and act accordingly.

See also https://github.com/act-rules/act-rules.github.io/pull/1661#discussion_r705136203 where giving access to the computer's microphone seems fairly similar to a test instruction.

Jym77 avatar Sep 09 '21 09:09 Jym77