act-rules.github.io Orientation of page not restricted rule doesn't detect rotate: 90deg [b33eff]

The rule's applicability includes transform: rotate(90deg) but not rotate: 90deg

https://developer.mozilla.org/en-US/docs/Web/CSS/rotate

https://act-rules.github.io/rules/b33eff

I can do a PR for this

Jul 30 '21 13:07 dd8

Thought Carlos had responded. Sorry Mark. Yeah makes sense. A PR would be much appreciated!

Aug 10 '21 13:08 WilcoFiers

rotate seems to have very limited support (Firefox, and partly for Safari). We should at least add a big "Accessibility Support" note with it; maybe wait until it has wider support before doing the change.

Aug 19 '21 09:08 Jym77

rotate seems to have very limited support (Firefox, and partly for Safari). We should at least add a big "Accessibility Support" note with it; maybe wait until it has wider support before doing the change.

The orientation rule applies to mobile only - so practically this means Android and iOS. iOS 14 supports rotate: and will ship on 16 September 2021. iOS auto-updates so most iOS users will be on iOS 14 with Safari 14 a few weeks from now.

Edit: An update for Chrome is in in progress - rotate: support was added and is hidden behind a flag. Blocking issue seems to be performance when animating rotate: in parallel with other transforms, but seems to be nearly ready to ship - and is likely to be prioritised now that Firefox and Safari support it: https://bugs.chromium.org/p/chromium/issues/detail?id=696374

Aug 21 '21 19:08 dd8

I think it's a good thing to add, potentially with a note on limited support? Mark can you create the PR for this?

Sep 28 '21 09:09 WilcoFiers

Yes, but might take a week or two to get round to it.

Oct 05 '21 17:10 dd8

@dd8 Any update on this Mark?

Nov 02 '21 10:11 WilcoFiers

Hoping to get to this at the end of this week.

Nov 09 '21 15:11 dd8

@WilcoFiers PR https://github.com/act-rules/act-rules.github.io/pull/1742 submitted

PS I don't have permissions to assign myself or add labels per the PR Template

Nov 12 '21 16:11 dd8

Thanks @dd8 Assignments done

Nov 12 '21 16:11 carlosapaduarte

@carlosapaduarte @dd8 , has a PR been made on your request regarding adding an updated example? Would you like to propose one if not? I'm happy to file if you want me to, just looking for clarity on where we are on this issue. Thank you both for your time.

Nov 07 '22 15:11 ChrisLoiselle

@carlosapaduarte @dd8 , has a PR been made on your request regarding adding an updated example? Would you like to propose one if not? I'm happy to file if you want me to, just looking for clarity on where we are on this issue. Thank you both for your time.

It's been done in https://github.com/act-rules/act-rules.github.io/pull/1742 - just waiting for another approval

Nov 15 '22 16:11 dd8