act-rules.github.io icon indicating copy to clipboard operation
act-rules.github.io copied to clipboard

Image non empty acc name - revised PR

Open dd8 opened this issue 5 years ago • 2 comments

The PR replaces https://github.com/act-rules/act-rules.github.io/pull/1208

Reason for new PR: rule has been renamed, and many changes from original PR were merged in https://github.com/act-rules/act-rules.github.io/pull/1300

This PR:

  • restricts the applicability to elements that render an image (to make <img/> and <div style='background-image:none'> inapplicable because they have no visual rendering, and are not voiced)
  • adds <img/> as an inapplicable example
  • adds additional failed examples like <img srcset='...'/>

Closes issue(s):

  • closes issue described here https://github.com/act-rules/act-rules.github.io/issues/1124#issuecomment-578042900

Need for Final Call: This will require a 2 week Final Call


Pull Request Etiquette

When creating PR:

  • [ ] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • [ ] Add yourself (and co-authors) as "Assignees" for PR.
  • [ ] Add label to indicate if it's a Rule, Definition or Chore.
  • [ ] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • [ ] Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • [ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

dd8 avatar Jul 08 '20 14:07 dd8

I don't have repo rights to do these:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

Can someone with repo maintainer rights do them? Thanks.

dd8 avatar Jul 08 '20 15:07 dd8

I think that's all the requested changes addressed. I think it's important to reference the HTML represents nothing definition somewhere in the rule, but I'm not convinced doing it from the examples is the right place.

dd8 avatar Jul 12 '20 13:07 dd8