datahub-helm icon indicating copy to clipboard operation
datahub-helm copied to clipboard

Remove all CPU limits

Open red8888 opened this issue 1 year ago • 3 comments

Describe the bug You shouldn't be setting CPU limits: https://home.robusta.dev/blog/stop-using-cpu-limits

Also, helm currently has a regression that prevents you from nulling out a value from a parent chart so we can't remove CPU limits from the config in our values.yaml we specify

Its a bad practice in the first place. Could just drop all the CPU limits you've configured in this chart?

red8888 avatar Mar 27 '24 20:03 red8888

Can you please specify in which pods / deployments the issue occurs, for me the websevers only have limits on the memory, but not on cpu. Perhaps you're not specifying the requests and limits yourself in the values file. I think that the current requests and limits in the chart are quite sensible, and provide a good starting point.

gschuurman avatar Apr 08 '24 07:04 gschuurman

@gschuurman you can do a code search and see all of them theres a bunch: https://github.com/search?q=repo%3Aacryldata%2Fdatahub-helm+cpu%3A&type=code

image

red8888 avatar Apr 18 '24 22:04 red8888