AUTH_OIDC_BASE_URL not beeing set correctly if ingress disabled

[rathberm]

Describe the bug

The variable AUTH_OIDC_BASE_URL is set in the frontend container and is needed for setting up SSO. Since Helm Chart Version 0.2.160 the variable is set depending on the Host URL set in the ingress definition. If ingress.enabled: false is set, the variable is still initialized based on the value of the ingress host, which is chart-example.local. Since this placeholder example Ingress host is not even visibly set in the Values File but instead only in the values file of the subchart, this behavior is unintuitive and not what I expected. If you try to set AUTH_OIDC_BASE_URL as an extraEnvs variable and ingress.enabled: false is set, its value will always be overwritten by chart-example.local on deploy.

I think this behavior could be fixed by using an if clause to only set AUTH_OIDC_BASE_URL to the value of datahub-frontend.ingress.hosts.host if ingress.enabled: true.

I understand that SSO only works if using TLS (so AUTH_OIDC_BASE_URL is mostly only needed in combination with an ingress) and for that you need to set up an ingress. But in our case the ingress was set up manually which led to this problem.

To Reproduce Deploy the datahub chart with datahub-frontend.ingress.enabled: false and datahub-frontend.ingress.hosts.host not set.

Expected behavior AUTH_OIDC_BASE_URL is not set or is set to the values of AUTH_OIDC_BASE_URL set in the extraEnvs Part of the values file.

I would be willing to implement this fix, please let me know what you think about it.

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

[rathberm]

This is still a bug in datahub-0.2.175.

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

[leszekbulawa]

This workaround seems to be feasible:

    ingress:
      enabled: false
      hosts:
        - host: {{ .Values.domain }}
          paths: []
          redirectPaths: []

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

[7onn]

I think this behavior could be fixed by using an if clause to only set AUTH_OIDC_BASE_URL to the value of datahub-frontend.ingress.hosts.host if ingress.enabled: true.

Following this issue to be notified if this will change. Not proud of how I implemented this:

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

[github-actions[bot]]

This issue was closed because it has been inactive for 30 days since being marked as stale.

[jtv8]

Still an issue in 1.3.0, was not stale, should not have been closed

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io