datahub-helm icon indicating copy to clipboard operation
datahub-helm copied to clipboard

Published 20 hours ago • verified publisher icon acryldata

allow for specifying setup job resources

Open davidspek opened this issue 3 years ago • 3 comments

This PR allows for setting the resources on the setup job. Currently, the requested resources are quite high, in particular for the elasticsearch setup job that just runs curl, which can cause unnecessary cluster scale ups. This PR makes is possible to specify the resources for the various setup jobs so people can configure these according too their needs.

Checklist

  • [ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [ ] Links to related issues (if applicable)
  • [ ] Tests for the changes have been added/updated (if applicable)
  • [ ] Docs related to the changes have been added/updated (if applicable)

davidspek avatar Oct 10 '22 21:10 davidspek

hey @DavidSpek, thanks for the contribution. Looks good. Left one comment.

szalai1 avatar Oct 11 '22 12:10 szalai1

Thanks for the review. I've fixed the typo so it should be good now.

davidspek avatar Oct 11 '22 12:10 davidspek

I've just fixed the merge conflict.

davidspek avatar Oct 11 '22 17:10 davidspek

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

github-actions[bot] avatar Nov 27 '22 02:11 github-actions[bot]

Hello @DavidSpek

Could you resolve the chart.yaml conflict? With that done we can merge this in :)

pedro93 avatar Dec 07 '22 15:12 pedro93

Closing PR in favor of https://github.com/acryldata/datahub-helm/pull/224

pedro93 avatar Dec 28 '22 12:12 pedro93