datahub-helm icon indicating copy to clipboard operation
datahub-helm copied to clipboard

Published 20 hours ago • verified publisher icon acryldata

feat(charts): Support Rancher Catalog (#130)

Open k-ebu opened this issue 2 years ago • 6 comments

Refference

Checklist

  • [x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [x] Links to related issues (if applicable)
    • #130
  • [ ] Tests for the changes have been added/updated (if applicable)
  • [ ] Docs related to the changes have been added/updated (if applicable)

Closes #130

k-ebu avatar Jun 15 '22 07:06 k-ebu

Rancher Catalog Page preview: image

prerequisites values preview: image

datahub values preview: image

k-ebu avatar Jun 15 '22 08:06 k-ebu

@k-ebu Thanks for all these changes!! Sorry about the late reply.

Does this mean we need to keep questions.yaml in sync every time we add a new variable? Want to make sure the process is set up correctly.

Also are there any ways to enforce this if this is true? (Like a lint GitHub actions to check they are in sync)

dexter-mh-lee avatar Jun 21 '22 17:06 dexter-mh-lee

@dexter-mh-lee Thank you.

I don't think that all variables in values.yml need to be able to be changed from the GUI.

For example, the Image repository can be changed from the GUI because we sometimes use Private Registry, but the Image tag input field was removed in the following commit because it is operated to be changed by the developer when the Chart is released.

b894723

If users want to change the values in more detail, Rancher has the feature to edit the YAML file directly. I think it is better to set items in questions.yml that are commonly changed, and edit questions.yml only when such items are newly added.

k-ebu avatar Jun 22 '22 00:06 k-ebu

@dexter-mh-lee Could you review it?

k-ebu avatar Sep 08 '22 02:09 k-ebu

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

github-actions[bot] avatar Oct 09 '22 02:10 github-actions[bot]

ping

eburairu avatar Oct 09 '22 04:10 eburairu

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

github-actions[bot] avatar Nov 13 '22 02:11 github-actions[bot]

This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io.

github-actions[bot] avatar Jan 01 '23 02:01 github-actions[bot]

Closing stale PR.

github-actions[bot] avatar Feb 01 '23 02:02 github-actions[bot]