datahub-helm icon indicating copy to clipboard operation
datahub-helm copied to clipboard

feat(prerequisites): add postgresql to prerequistes Helm chart as an optional dependency

Open Masterchen09 opened this issue 2 years ago • 3 comments

This PR adds the postgresql chart from the Bitnami chart repository as an optional and by default disabled dependency to the prerequisites Helm chart. Additionally I have added some example configuration to the values.yaml of the datahub Helm chart for documentation purposes (as far as I know the usage of PostgreSQL is not documented anywhere, as I had to search the repository for the correct values etc.).

I am not sure if this should be part of the official Helm charts, but as I wanted to use PostgreSQL in my local deployment and I already changed the charts accordingly, maybe others also want to use it and do not want to do the work twice.

If this PR is merged, we could also add some documentation here, to explain how to use PostgreSQL, etc.

See also issue #49.

Checklist

  • [x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [x] Links to related issues (if applicable)
  • [x] Tests for the changes have been added/updated (if applicable)
  • [x] Docs related to the changes have been added/updated (if applicable)

Masterchen09 avatar May 26 '22 10:05 Masterchen09

Hi! Any news about this PR? Maybe smth i can help with? Really useful feature

Wilderone avatar Aug 11 '22 06:08 Wilderone

The failing action is most likely a result of https://github.com/bitnami/charts/issues/10833 and should work now when rebasing on master.

chgl avatar Aug 30 '22 21:08 chgl

I have rebased the branch on master, now the checks are passing.

Masterchen09 avatar Aug 31 '22 11:08 Masterchen09