cli icon indicating copy to clipboard operation
cli copied to clipboard

CLI-1192: Symfony 6.3.4 breaks checklists

Open danepowell opened this issue 1 year ago • 0 comments

Checklists are supposed to look like this:

https://github.com/acquia/cli/assets/1984514/49584627-80e9-41dc-9fbc-3faf3d0bde79

Upgrading to 6.3.4 breaks them:

https://github.com/acquia/cli/assets/1984514/147ac07a-e6cb-4dfe-97f7-3d23db6f25ce

The culprit is this PR: https://github.com/symfony/symfony/pull/51378

When the progress bar advances and ConsoleSectionOutput->doWrite('my message\n', false) is called, the patch changes this to $message = 'my message' and $newline = true. You'd think this would be equivalent, but apparently it's not, as it results in too many lines being cleared, erasing the checklist and previous console output.

Our checklist and spinner classes are here: https://github.com/acquia/cli/tree/main/src/Output

danepowell avatar Nov 01 '23 19:11 danepowell