'root_domain' key missing on `acsf_tools_config.default.yml`

[marcoscano]

On the 10.x-dev branch, the acsf_tools_config.default.yml file doesn't contain a root_domain key. However, the code in \Drush\Commands\acsf_tools\AcsfToolsUtils::getRestConfig() is assuming it's present:

    $config = new \stdClass();
    $config->site_id = $yaml['site_id'];
    $config->username = $yaml['rest_api_user'];
    $config->password = $yaml['rest_api_key'];
    $config->prod_uri = $yaml['rest_factories']['prod'];
    $config->test_uri = $yaml['rest_factories']['test'];
    $config->dev_uri = $yaml['rest_factories']['dev'];
    $config->root_domain = $yaml['root_domain'];
    $config->subdomain_pattern = $yaml['subdomain_pattern'];
    $config->prod_web = $yaml['prod_web'];
    $config->dev_web = $yaml['dev_web'];
    $config->email_logs_from = $yaml['email_logs_from'];
    $config->email_logs_to = $yaml['email_logs_to'];

I'll submit a PR just adding that empty key to the scaffold file, but I'll probably not be able to expand the documentation to include it, since I'm not familiar to what this is used for.

[marcoscano]

PR to avoid the warning: https://github.com/acquia/acsf-tools/pull/142 As I mentioned, if the docs could be expanded as well to explain what this is, it would be great! :)

[vbouchet31]

I merged the PR to avoid the warning. Keeping this ticket opened for the doc part.