acquia-sdk-php icon indicating copy to clipboard operation
acquia-sdk-php copied to clipboard

Upgrade to Guzzle 6

Open cpliakas opened this issue 10 years ago • 10 comments

cpliakas avatar Apr 19 '14 17:04 cpliakas

:+1:

On install, we currently get warnings like:

Package guzzle/inflection is abandoned, you should avoid using it. Use guzzle/guzzle instead.
Package guzzle/common is abandoned, you should avoid using it. Use guzzle/guzzle instead.
Package guzzle/stream is abandoned, you should avoid using it. Use guzzle/guzzle instead.
Package guzzle/parser is abandoned, you should avoid using it. Use guzzle/guzzle instead.
...

geerlingguy avatar Apr 17 '15 15:04 geerlingguy

Guzzle 6 is out. The AWS PHP SDK and Zendesk API libs both depend on Guzzle 6. Please consider skipping 5 and jumping straight to 6.

skwashd avatar Oct 21 '15 09:10 skwashd

@cpliakas @Zlender do you have updates? We have some problems with this, because right now we should working with 2 different versions of guzzle in one project. And it's a little bit complex because we should handle different Exception types.

Maybe it will be better to prepare some adapters and decouple guzzle at all? It will be useful because end-user can decide which version he wants to use.

IlyaPokamestov avatar Jul 06 '16 11:07 IlyaPokamestov

poking this again, updating to Guzzle 6 would be very nice.

fiasco avatar May 09 '17 02:05 fiasco

Adding another comment to this to bump this issue as we're starting to use this library more for our deployments.

typhonius avatar Jul 14 '17 02:07 typhonius

The version of Guzzle being used here (3.x) is almost four years old. That's gotta be insecure, not to mention the fact that it produces numerous warnings whenever a project depending on this sdk is installed.

We'd love to use this in BLT, but I don't know that I'm willing to do so if it's going to produce so many bright yellow deprecation warnings, which will scare and annoy a lot of users. That's going to create a negative image for BLT and Acquia in general.

Can this be prioritized?

Edit: a quick Google reveals at least one known security issue with Guzzle 3, who knows how many more are out there: https://github.com/guzzle/guzzle3/issues/71

danepowell avatar Oct 27 '17 21:10 danepowell

@Dane: This repository was maintained by people that no longer work at Acquia. It is currently unsupported.

aaronpacheco avatar Oct 30 '17 13:10 aaronpacheco

@aaronpacheco can the readme be upgraded to reflect this?

skwashd avatar Oct 30 '17 13:10 skwashd

Done.

aaronpacheco avatar Oct 30 '17 13:10 aaronpacheco

Here is a new version of the SDK that uses the v2 Cloud API: https://github.com/typhonius/acquia-php-sdk-v2

I haven't tested that yet, but assuming it's functional, I'd recommend everyone deprecating this and moving to use and support acquia-php-sdk-v2.

danepowell avatar Nov 02 '17 16:11 danepowell