BUSE icon indicating copy to clipboard operation
BUSE copied to clipboard

user operations errors should be properly converted to network byte order

Open rutsky opened this issue 9 years ago • 1 comments

Currently all errors are set like this:

reply.error = aop->write(chunk, len, from, userdata);

which requires to use ntohl inside user buse_operations.

I suggest to handle byte order on BUSE side, e.g.:

reply.error = htonl(aop->write(chunk, len, from, userdata));

rutsky avatar Jan 31 '16 22:01 rutsky

I have a question: Doesn't the order of received byte sent after a write request need to be reversed as well ? If not, why?

CaesarJeries avatar Nov 24 '18 16:11 CaesarJeries