chromaprint icon indicating copy to clipboard operation
chromaprint copied to clipboard
verified publisher icon acoustid

ffmpeg 7.0 support

Open sebastinas opened this issue 1 year ago • 2 comments

chromaprint fails its tests with ffmpeg 7.0:

[ RUN      ] FFmpegAudioReaderTest.ReadRaw
./src/audio/ffmpeg_audio_reader_test.cpp:18: Failure
Expected equality of these values:
  2
  reader.GetChannels()
    Which is: 1

[  FAILED  ] FFmpegAudioReaderTest.ReadRaw (7 ms)

See for example https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1072404. Arch and Debian have applied a similar patch to address this issue, but users are experiencing issues. It would be great if ffmpeg 7.0 support could be added.

sebastinas avatar Aug 12 '24 07:08 sebastinas

As I found out after some debugging (with having literally no clue about ffmpeg development ^^), at least the problem I’ve seen and described in the aforementioned is probably already fixed by commit 82781d02cd3063d071a501218297a90bde9a314f.

At least the test seem to run through for me and fpcalc produced some value again.

calestyo avatar Jan 01 '25 02:01 calestyo

@lalinsky Could you perhaps release a new version with the few commits since 1.5.1?

calestyo avatar Jan 01 '25 05:01 calestyo