chromaprint icon indicating copy to clipboard operation
chromaprint copied to clipboard

Published 20 hours ago • verified publisher icon acoustid

Port to ffmpeg 5.0

Open Yesterday17 opened this issue 2 years ago • 2 comments

Thanks #108

I'm not experienced in C++, and not familiar with ffmpeg. Please review the code carefully :pray:

This pull request also fixes an existing issue as a by-product of refactoring the Read method. Now fpcalc can calculate fingerprint of m4a files correctly. The problem was found by @kaaass while using fingerprint with MusicBrainz. fpcalc would run into an infinite loop when computing fingerprint of m4a files on my laptop.

I tested this PR on a WAV file and a FLAC file. The fingerprint did not change after the patch(at least for these two files).

Fixes #33 Fixes #110

Yesterday17 avatar Apr 26 '22 22:04 Yesterday17

duplicated of https://github.com/acoustid/chromaprint/pull/108 ?

sergiomb2 avatar Jun 25 '22 12:06 sergiomb2

duplicated of #108 ?

Fix in #108 does not work correctly.

Yesterday17 avatar Jun 26 '22 01:06 Yesterday17

Thank you for the patch, but I'll end up using my version here - https://github.com/acoustid/chromaprint/pull/120

lalinsky avatar Nov 04 '22 20:11 lalinsky