chromaprint icon indicating copy to clipboard operation
chromaprint copied to clipboard

Port to ffmpeg 5.0

Open berolinux opened this issue 2 years ago • 4 comments

Replace removed functionality like accessing the codec context from an AVStream and avcodec_decode_audio4()

Signed-off-by: Bernhard Rosenkränzer [email protected] Fixes: https://github.com/acoustid/chromaprint/issues/78

berolinux avatar Jan 17 '22 03:01 berolinux

With this patch the build fails with ffmpeg 4.4:

In file included from /<<PKGBUILDDIR>>/src/cmd/fpcalc.cpp:7:
/<<PKGBUILDDIR>>/src/audio/ffmpeg_audio_reader.h:144:69: error: invalid conversion from ‘const AVInputFormat*’ to ‘AVInputFormat*’ [-fpermissive]
  144 |         ret = avformat_open_input(&m_format_ctx, file_name.c_str(), m_input_fmt, &m_input_opts);
      |                                                                     ^~~~~~~~~~~
      |                                                                     |
      |                                                                     const AVInputFormat*

sebastinas avatar Feb 02 '22 21:02 sebastinas

thanks mate successful build with ffmpeg5

Replace removed functionality like accessing the codec context from an AVStream and avcodec_decode_audio4()

Signed-off-by: Bernhard Rosenkränzer [email protected] Fixes: #78

blackPantherOS avatar Feb 24 '22 10:02 blackPantherOS

It builds fine, but it throws errors at runtime because it doesn't account for AVERROR_EOF

antonio-rojas avatar Mar 19 '22 18:03 antonio-rojas

as far as I can tell this is going to need a lot more to work correctly

q66 avatar Apr 21 '22 17:04 q66

Thank you for the patch, but I'll end up using my version here - https://github.com/acoustid/chromaprint/pull/120

lalinsky avatar Nov 04 '22 20:11 lalinsky