The function signatures and behavior of .walk & .walkSync are not the same

[arnorhs]

The callback receives different arguments and in .walk the full file path is passed with each file, but in .walkSync the file is stand alone and you have to concatenate

I don't feel strongly about which approach is better or anything, just that they should be the same.. They should even have the same unit test with some tweaks

[aconbere]

Yep, looking at that there's some pretty obvious bugs (potentially alleviated by updating the tests!) at the very least the walkSync callback should actually be getting what the docs say (error, path, dirs, name) and I haven't looked closely at the behavior with regards to the paths, but I agree making them the same seems like the right way to go (It sure looks like I assumed they were the same when I wrote it).

Again I wont have much time to look at this until the weekend, so if you'd like to take a swing, please please please do.

And I think the only constraint I would put on that, is that we should bump the major version number so that if anyone has worked around these bugs we don't screw up their programs.

[arnorhs]

Yeah, I agree about bumping the major version.

I will take a swing at that, since it also helps another project I'm contributing to. I'll at least try to make it so the .walkSync function has the same signature and behavior as the .walk function.

Thanks