Plumble icon indicating copy to clipboard operation
Plumble copied to clipboard

Fix for JoinChannel scrolls channel list to button Issue#178

Open olzzon opened this issue 7 years ago • 3 comments

(e.g. use public server Libre Antenne) Using the release candidate from Fdroid 3.3.0rc1: When joining a channel on a larger server the display scrolls to another place on the list. So it can be hard to find the group you joined. The version 3.2.0 in playstore (with the old JoinChannel function) does not have this issue.

Changing mChannelView.smoothScrollToPosition to mChannelView.scrollToPosition (in ChannelListFragment.java->scrollToChannel) solves the problem.

Are there any reasons for using the smoothScrollToPosition instead og scrollToPosition? and do you think it´s because of a certain SDK version? Otherwise I propose to change it.

olzzon avatar Sep 01 '17 12:09 olzzon

3q

hrh757 avatar Sep 11 '17 14:09 hrh757

I'm alright with this change, but I'd like to know the reason why switching to scrollToPosition intead of smoothScrollToPosition fixes the problem (it could be that scrollToPosition's immediacy covers up the underlying root problem here).

Is there any interesting logging done when the scroll overshoot happens?

acomminos avatar Oct 08 '17 21:10 acomminos

I´ll look into it, next week, and see what I can find. :)

olzzon avatar Oct 10 '17 11:10 olzzon