Antoine Colombier
Antoine Colombier
No problem - I'll mark it as draft for now
Overall, I'm not sure this is a good idea to drop support for Ubuntu 22.04/Qt 6.2 LTS. A few reasons for that: - Ubuntu 24.04 doesn't rely on a LTS...
> could we support both 22.04 and 24.04, at least till we move to support the next Qt LTS version? How about this?
Hi @robbert-vdh , do you have interest in completing this? I'll mark this as a draft for now, but feel free to move it to ready if you get a...
Before this can get reviewed, could you please you remove all changes in the diff unrelated or uneeded to this feature (spaces reformatting, comment cruft). This also hopefully bring the...
> pre-commit is doing that stuff pre-commit shouldn't change old stuff, but it looks like a lot of reformatting was done, making the PR nearly impossible to review. I suspect...
It's likely not git, git cannot do such a thing. This is likely some "linting on save" feature on VS - @JoergAtGithub do you know about this? Is there a...
Is this format imposed on you? Did you disable it to work with Mixxx repo?
Hi @Eve00000 , is this PR superseding #13157 and #12993? If yes, can we close them and keep further work within this branch to limit PR proliferation?
I haven't looked at the code yet as is doesn't seem to be ready to review looking at the CI result. My 2 cents on the overall look is that...