Andrew Coates
Andrew Coates
Another question, I don't see anything in here that actually disables the outer window. So, this isn't really a modal dialog at all, but just a window? This probably needs...
For the modal sizing, I was thinking more along the lines of where we would control the size of the modal dialog window based on the size of the content...
We probably need to add code to call BringIntoView on the element - since programmatic focus doesn't appear to bring the element into view automatically.
I think is even worse. With this it would be impossible to write a JS RN component that provides a toggle pattern. Ex: FURN's JS checkbox will be unable to...
This looks incomplete. The logic for Natural is more complex. I'm not exactly sure what the text direction should be based off by default. -- User locale? Text content? Also...
Are you using the new arch or the old arch? NativeModules are not supported in the new arch - you should use TurboModules instead.
onPressIn and onPressOut are implemented using a pressable inside the JS in TextInput. https://github.com/facebook/react-native/blob/33aa7b91617bb6e2b9689850e8740c97e01464de/packages/react-native/Libraries/Components/TextInput/TextInput.js#L619 We shouldn't be emitting these events from native. This looks like onPressIn was implemented incorrectly. Instead...
> > onPressIn and onPressOut are implemented using a pressable inside the JS in TextInput. https://github.com/facebook/react-native/blob/33aa7b91617bb6e2b9689850e8740c97e01464de/packages/react-native/Libraries/Components/TextInput/TextInput.js#L619 > > We shouldn't be emitting these events from native. > > This looks...