acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

DNS-Challenge: fix DESec.io -> Fix return values in add txt record function

Open rICTx-T1D opened this issue 1 month ago • 5 comments

Changed return values for error handling in txt record addition. DESec.io create txt-record but PUT was indicated as failed

Test pass OK

rICTx-T1D avatar Nov 05 '25 18:11 rICTx-T1D

Welcome READ ME !!!!! Read me !!!!!! First thing: don't send PR to the master branch, please send to the dev branch instead. Please read the DNS API Dev Guide. You MUST pass the DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

github-actions[bot] avatar Nov 05 '25 18:11 github-actions[bot]

#2180

rICTx-T1D avatar Nov 05 '25 19:11 rICTx-T1D

why return 0 when there is add error ?

Neilpang avatar Nov 09 '25 17:11 Neilpang

why return 0 when there is add error ?

When return 1 or higher than 0, acme think its not okay and delete the fresh created dns record. DESec.io has return error but the record was successfully created and is displaying on GUI.

Maybe the API doesn't retturn correct status code. But this is out over our scope here.

rICTx-T1D avatar Nov 18 '25 14:11 rICTx-T1D

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Neilpang avatar Nov 18 '25 20:11 Neilpang