acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Fix/ultradns zone detection

Open amworden opened this issue 1 month ago • 4 comments

The original code fetched the zones list with GET "zones", but the API returns at most 100 zones. Accounts with more zones failed to resolve because the target zone could be beyond that limit.

Fix: First tries direct zone access (GET "zones/${zone_name}"), bypassing the 100-zone cap and falling back to the list when needed.

Result: Supports accounts with more than 100 zones.

amworden avatar Oct 27 '25 21:10 amworden

Welcome READ ME !!!!! Read me !!!!!! First thing: don't send PR to the master branch, please send to the dev branch instead. Please read the DNS API Dev Guide. You MUST pass the DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

github-actions[bot] avatar Oct 27 '25 21:10 github-actions[bot]

Welcome READ ME !!!!! Read me !!!!!! First thing: don't send PR to the master branch, please send to the dev branch instead. Please read the DNS API Dev Guide. You MUST pass the DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

should be good

amworden avatar Oct 27 '25 21:10 amworden

@Neilpang is this ok to go in?

pentadam avatar Dec 03 '25 14:12 pentadam

Welcome READ ME !!!!! Read me !!!!!! First thing: don't send PR to the master branch, please send to the dev branch instead. Please read the DNS API Dev Guide. You MUST pass the DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

good

pentadam avatar Dec 03 '25 14:12 pentadam

you MUST pass the DNS-API-Test. you MUST pass the DNS-API-Test. you MUST pass the DNS-API-Test. you MUST pass the DNS-API-Test.

Neilpang avatar Dec 17 '25 19:12 Neilpang