acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

tr issue on FreeBSD never hit prod

Open dlangille opened this issue 3 months ago • 7 comments

See #4160

This fix isn't in prod. It wasn't in 3.0.5

https://github.com/acmesh-official/acme.sh/blob/3.0.5/acme.sh#L438

Was it missed in a merge?

dlangille avatar Sep 10 '25 18:09 dlangille

Please upgrade to the latest code and try again first. Maybe it's already fixed. acme.sh --upgrade If it's still not working, please provide the log with --debug 2, otherwise, nobody can help you.

github-actions[bot] avatar Sep 10 '25 18:09 github-actions[bot]

Please upgrade to the latest code and try again first. Maybe it's already fixed. acme.sh --upgrade If it's still not working, please provide the log with --debug 2, otherwise, nobody can help you.

Nope, that's not it bot.

dlangille avatar Sep 10 '25 18:09 dlangille

what is the freebsd version you use ?

Neilpang avatar Sep 11 '25 19:09 Neilpang

Me, personally, FreeBSD 14.2 and 14.3

The OP (via https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289444) may reply here with their information.

dlangille avatar Sep 11 '25 19:09 dlangille

i think i finally found real culprit:

look at this:

23:12,ketas@green:~> echo abc | tr '[a-z]' '[A-Z]' | cat -vetu Ac$ 23:12,ketas@green:~> echo abc | env LANG=C tr '[a-z]' '[A-Z]' | cat -vetu ABC$ 23:13,ketas@green:~>

so this issue appeared in 11.x since now tr is localized? i never checked where that change is

i'm unsure if that is right or not. maybe it was all wrong in the first place. tr has bitten my ass before with LANG != C

blame me for not running all envs on C, only some

but this issue will bite people who run localized shells and then they don't

which confuses hell out of anyone

this isn't the first time locale just breaks stuff. i mean language differences are cool, except when it breaks interoperability

so it's not much of a fbsd version i'm using, it's more like which locale

it's up to debate if programs or users should set locales to predictable settings. or why tr even does that. i mean it's a text processor and text is also !english but it confuses hell out of anyone who codes if a-z suddenly starts including things like üöõä

not even bringing in the wonderful world of utf-8 which allows one to create a big mess without even realizing it

ketas avatar Sep 11 '25 20:09 ketas

I don't know enough about the problem to help you. I appreciate the fix. I'll get it into the FreeBSD port and see how people react.

dlangille avatar Sep 21 '25 19:09 dlangille

seems good fix eh

surely that doesn't bite any punycode users? that's done before this?

i think certs/acme/etc works on ascii only

ketas avatar Sep 21 '25 21:09 ketas