acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Optimize root domain search through api

Open keryfan opened this issue 8 months ago • 8 comments

keryfan avatar Mar 26 '25 10:03 keryfan

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

github-actions[bot] avatar Mar 26 '25 10:03 github-actions[bot]

I have read the guide. This PR just adds filtering to root-domains check to speed-up the process, the rest of the code is same.

keryfan avatar Apr 17 '25 14:04 keryfan

please follow the dns api test: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Any changes to the dns api hook must be verified by the dns api test.

Neilpang avatar Apr 23 '25 18:04 Neilpang

please follow the dns api test: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Any changes to the dns api hook must be verified by the dns api test.

Please check again - I've updated settings for actions and added corresponding secrets to repo. Then triggered activity by syncing latest changes from repo to fork.

keryfan avatar May 08 '25 14:05 keryfan

it's not passing

https://github.com/fornex-com/acme.sh/actions/runs/14908908134

Neilpang avatar May 08 '25 18:05 Neilpang

it's not passing

https://github.com/fornex-com/acme.sh/actions/runs/14908908134

For some reason it fails on the process of creating container for clearlinux:latest, even before starting cert request. image

But at the same time all tests with different docker images were successful.

I also tried to run acmetest locally and also got error when testing only clearlinux platform on the phase of creation of container itself.

image

keryfan avatar May 14 '25 08:05 keryfan

please run it again, it should work.

Neilpang avatar May 17 '25 20:05 Neilpang

Please check https://github.com/fornex-com/acme.sh/actions/runs/14908908134. All actions completed.

keryfan avatar May 27 '25 15:05 keryfan

latest test is not passing ?

https://github.com/fornex-com/acme.sh/actions/runs/15637616695

Neilpang avatar Jun 21 '25 20:06 Neilpang

Please check again, all checks have passed.

keryfan avatar Jun 25 '25 07:06 keryfan